Skip to content

launch banner#1672

Merged
Alek99 merged 2 commits intomainfrom
carlos/some-landing-followups
Oct 23, 2025
Merged

launch banner#1672
Alek99 merged 2 commits intomainfrom
carlos/some-landing-followups

Conversation

@carlosabadia
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Updated landing page banner for Product Hunt launch promotion with countdown timer and simplified number pattern assets.

Key Changes

  • Replaced LinkedIn post banner with Product Hunt launch banner featuring 50% discount promotion
  • Added countdown timer showing time remaining until October 25, 2024 deadline
  • Implemented deadline-based visibility logic - banner only shows before deadline
  • Refactored numbers_pattern component to use single image asset instead of four variants per theme
  • Consolidated ellipse animation functions and improved gradient masking logic
  • Renamed reversed parameter to reverse for better clarity across all landing page views
  • Removed 8 unused pattern image assets (numbers-img.webp variants)

Confidence Score: 1/5

  • This PR has critical bugs that will break functionality in production
  • Two critical bugs found: (1) the deadline year is set to 2025 instead of 2024, meaning the banner will never show until next year, and (2) the image path is missing a leading /, which will cause 404 errors for all pattern images. Both issues must be fixed before merging.
  • Pay close attention to pcweb/components/hosting_banner.py and pcweb/components/numbers_pattern.py - both contain critical bugs

Important Files Changed

File Analysis

Filename Score Overview
pcweb/components/hosting_banner.py 2/5 Updated banner for Product Hunt launch with timer and deadline logic - contains critical date bug (year 2025 instead of 2024)
pcweb/components/numbers_pattern.py 2/5 Refactored pattern component with simplified image handling and gradient masks - contains critical path bug (missing leading /)

Sequence Diagram

sequenceDiagram
    participant User
    participant Browser
    participant HostingBannerState
    participant Timer
    
    User->>Browser: Load landing page
    Browser->>HostingBannerState: on_mount trigger
    HostingBannerState->>HostingBannerState: check_deadline()
    HostingBannerState->>HostingBannerState: Compare current time vs DEADLINE
    alt Before deadline
        HostingBannerState->>Browser: Set show_banner = True
        Browser->>Browser: Render banner with timer
        Browser->>Timer: Start countdown (1s interval)
        Timer->>Browser: Update countdown display
    else After deadline
        HostingBannerState->>Browser: show_banner remains False
        Browser->>Browser: Banner not displayed
    end
    
    User->>Browser: Click X icon
    Browser->>HostingBannerState: hide_banner()
    HostingBannerState->>Browser: Set force_hide_banner = True
    Browser->>Browser: Hide banner immediately
Loading

8 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment thread pcweb/components/numbers_pattern.py
Comment thread pcweb/components/hosting_banner.py
@Alek99 Alek99 self-requested a review October 23, 2025 21:37
@Alek99 Alek99 merged commit b31f52e into main Oct 23, 2025
10 checks passed
@Alek99 Alek99 deleted the carlos/some-landing-followups branch October 23, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants